VOTE: bugfix geomajasContext*.xml filtering

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

VOTE: bugfix geomajasContext*.xml filtering

Jan Venstermans-2

Hallo Geomajas Devs,

I've run into a bug in Geomajas's configuration files. In both server and gwt2 project, files META-INF/geomajasContext.xml have been renamed to META-INF/geomajasContext*.xml. However, the filtering configuration has not been updated. This has lead to xml files where some maven properties (e.g. ${project.version}) have not yet been resolved in the deployed artefacts.

In gwt client project, the filtering configuration is correct.

Logged as http://jira.geomajas.org/browse/MAJ-1181

Proposing 2 pull requests:

https://github.com/geomajas/geomajas-project-server/pull/101

https://github.com/geomajas/geomajas-project-client-gwt2/pull/151 (fyi: on master branch, 2 test fail in showcase project)

please vote in the pull requests.

Kind regards,
-- 
-- Jan Venstermans
*DFC Software Engineering *
Brugsesteenweg 587
9030 Gent
T: +32 9 236 61 96
F: +32 9 236 54 12
W: http://www.dfc.be
Skype: dfcjanvenstermans

_______________________________________________
Majas-dev mailing list
[hidden email]
http://lists.geomajas.org/mailman/listinfo/majas-dev
Reply | Threaded
Open this post in threaded view
|

Re: VOTE: bugfix geomajasContext*.xml filtering

Pieter De Graef-2
Very nice catch! I'll check asap.

Cheers,

Pieter De Graef

2016-05-31 10:43 GMT+02:00 Jan Venstermans <[hidden email]>:

Hallo Geomajas Devs,

I've run into a bug in Geomajas's configuration files. In both server and gwt2 project, files META-INF/geomajasContext.xml have been renamed to META-INF/geomajasContext*.xml. However, the filtering configuration has not been updated. This has lead to xml files where some maven properties (e.g. ${project.version}) have not yet been resolved in the deployed artefacts.

In gwt client project, the filtering configuration is correct.

Logged as http://jira.geomajas.org/browse/MAJ-1181

Proposing 2 pull requests:

https://github.com/geomajas/geomajas-project-server/pull/101

https://github.com/geomajas/geomajas-project-client-gwt2/pull/151 (fyi: on master branch, 2 test fail in showcase project)

please vote in the pull requests.

Kind regards,
-- 
-- Jan Venstermans
*DFC Software Engineering *
Brugsesteenweg 587
9030 Gent
T: <a href="tel:%2B32%209%20236%2061%2096" value="+3292366196" target="_blank">+32 9 236 61 96
F: <a href="tel:%2B32%209%20236%2054%2012" value="+3292365412" target="_blank">+32 9 236 54 12
W: http://www.dfc.be
Skype: dfcjanvenstermans

_______________________________________________
Majas-dev mailing list
[hidden email]
http://lists.geomajas.org/mailman/listinfo/majas-dev



_______________________________________________
Majas-dev mailing list
[hidden email]
http://lists.geomajas.org/mailman/listinfo/majas-dev
Reply | Threaded
Open this post in threaded view
|

Re: VOTE SUCCESSFUL: bugfix geomajasContext*.xml filtering

Jan Venstermans-2
In reply to this post by Jan Venstermans-2
Hallo Devs,

Result of votes:

Vote count on fix in server project:
Kristof Heirwegh: +1 (binding)
Pieter De Graef: +1 (binding)
Jan Venstermans: +1

Vote count on fix in gwt2-client project:
Kristof Heirwegh: +1 (binding)
Pieter De Graef: +1 (binding)
Dosi Bingov: +1
Jan Venstermans: +1


Both votes are successful and the fixes have been merged to the respective master branches.

thanks for voting,
Jan Venstermans

Op 31/05/2016 om 10:43 schreef Jan Venstermans:

Hallo Geomajas Devs,

I've run into a bug in Geomajas's configuration files. In both server and gwt2 project, files META-INF/geomajasContext.xml have been renamed to META-INF/geomajasContext*.xml. However, the filtering configuration has not been updated. This has lead to xml files where some maven properties (e.g. ${project.version}) have not yet been resolved in the deployed artefacts.

In gwt client project, the filtering configuration is correct.

Logged as http://jira.geomajas.org/browse/MAJ-1181

Proposing 2 pull requests:

https://github.com/geomajas/geomajas-project-server/pull/101

https://github.com/geomajas/geomajas-project-client-gwt2/pull/151 (fyi: on master branch, 2 test fail in showcase project)

please vote in the pull requests.

Kind regards,
-- 
-- Jan Venstermans
*DFC Software Engineering *
Brugsesteenweg 587
9030 Gent
T: +32 9 236 61 96
F: +32 9 236 54 12
W: http://www.dfc.be
Skype: dfcjanvenstermans


-- 
-- Jan Venstermans
*DFC Software Engineering *
Brugsesteenweg 587
9030 Gent
T: +32 9 236 61 96
F: +32 9 236 54 12
W: http://www.dfc.be
Skype: dfcjanvenstermans

_______________________________________________
Majas-dev mailing list
[hidden email]
http://lists.geomajas.org/mailman/listinfo/majas-dev